Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shorten runProcess[Async]/runDartScript #161

Closed
seaneagan opened this issue Apr 9, 2015 · 1 comment
Closed

Shorten runProcess[Async]/runDartScript #161

seaneagan opened this issue Apr 9, 2015 · 1 comment

Comments

@seaneagan
Copy link
Contributor

In the spirit of log, fail, copy, delete, might be nice to shorten up runProcess, runProcessAsync, and runDartScript. run / runAsync seems clear enough to me without Process:

run('dart', ['--version'])

For runDartScript we could crib off of e.g. Pub.run, Dart2js.compile, etc. and have a Dart.run.

Dart.run('tool/foo.dart')

@devoncarew
@devoncarew
Copy link
Contributor

shorten up runProcess, ==> run('dart', ['--version'])

sgtm!

and have a Dart.run. Dart.run('tool/foo.dart')

also sgtm!

These are changes which we'd easily be able to deprecate the older method, and forward through to the newer ones. So, a it could be a relatively painless transition for users.

@seaneagan seaneagan mentioned this issue Apr 9, 2015
Merged
seaneagan added a commit that referenced this issue Apr 10, 2015
@seaneagan
Merge pull request #162 from seaneagan/shorten_run_process
2d3cdea 
Fix #161
jcollins-g pushed a commit to jcollins-g/grinder.dart that referenced this issue Feb 12, 2021
@munificent
Take the receiver into account when deciding how tightly to bind the …
f827336 
…"." in a single method call.

Fix google#161.

R=pquitslund@google.com

Review URL: https://chromiumcodereview.appspot.com//1177013005.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seaneagan @devoncarew