Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk commands need .bat appended to them on windows? #66

Closed
devoncarew opened this issue Jan 6, 2015 · 0 comments
Closed

sdk commands need .bat appended to them on windows? #66

devoncarew opened this issue Jan 6, 2015 · 0 comments

Comments

@devoncarew
Copy link
Contributor

We should see if these are necessary, and/or adversely affect windows installs which are already working.

jcollins-g pushed a commit to jcollins-g/grinder.dart that referenced this issue Feb 12, 2021
Previously, the formatter would get confused if it didn't indent enough
for several levels of expression nesting which later turned out to be
needed by later lines.

This addresses that. It does negatively impact perf (about 3x) but I
hope I can regain some of that in later optimizations.

Fixes google#49, google#66, google#75, google#83, and google#84.

R=pquitslund@google.com

Review URL: https://chromiumcodereview.appspot.com//802513004
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant