add repalcePathSeparator

[sunglim]

This repalcePathSeparator reduces the code size, and useful to support multi platform environment.

TEST=./grind tests

[devoncarew]

Hmm, does this make sense? I think you're including it for completeness. \ is a valid path char on unix OSes, although probably never used. Perhaps, the semantics of replacePathSeparator() can be changed slightly, to essentially allow '/' paths - unix or web paths - to work on windows?

I think this change is ok as is, or just as

if (Platform.isWindows) {
  return path.replaceAll('/', Platform.pathSeparator);
}

no strong feelings either way -

[sunglim]

I agree, just swtiching char is not perfect. and if replacePathSeperator work only windows, it's not useful.
closing then.

[devoncarew]

I have in the past used

path = path.replaceAll('/', Platform.pathSeparator);

in order to let unix and url paths ('/') work on windows. So, one path (foo/bar/baz) works on all OSes after being processed w/ the above replaceAll call. It's a shortcut to building up paths by joining components w/ the path separator. Perhaps this is not what you had in mind for replacePathSeparator()?

I can add this call in, but I think there'd also be room for something called normalizePath(), which only did the / ==> Platform.pathSeparator conversion.

[sunglim]

Well I think passing paths as string still imply issues. It is probably necessary to create FilePath class, something like a chromium FilePath https://code.google.com/p/chromium/codesearch#chromium/src/base/files/file_path.h

And remove all the String path.