Rename pubtools #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -151,9 +163,8 @@ class Dart2jsTools { | |||
| } | |||
|
|
|||
| String _execName(String name) { | |||
| if (Platform.isWindows) { | |||
| if (Platform.isWindows) | |||
There was a problem hiding this comment.
Generally, you do want to use braces with if statements, even if the if clause only has a single statement.
There was a problem hiding this comment.
Oh, sorry. Now I checked curly brace rule again. https://www.dartlang.org/articles/style-guide/#do-use-curly-braces-for-all-flow-control-structures
Thanks.
There was a problem hiding this comment.
Yeah, as you probably saw, the exception is when it all fits on one line. I personally tend to avoid even that use. I have used it once or twice for things like early return at the start of methods.
|
Cool, thanks! |
jcollins-g
pushed a commit
to jcollins-g/grinder.dart
that referenced
this pull request
Feb 12, 2021
This moves away from tuned split costs to unit-cost spans. Those compose better, which yields better results in nested expressions. Some of the existing tests get changed because the old output is better now. Fixes google#6. Fixes google#19. Fixes google#25. Fixes google#28. Fixes google#55. Fixes google#81. Fixes google#91. Fixes google#95. Fixes google#98. (!) R=pquitslund@google.com, sigmund@google.com Review URL: https://chromiumcodereview.appspot.com//824693005
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pub installtopub getand
pub updatetopub upgradeTEST=./grind init