Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3 Remove remaining references of RxFirestore from remote storage #1810

Merged
merged 6 commits into from Aug 24, 2023
Merged

#3 Remove remaining references of RxFirestore from remote storage #1810

merged 6 commits into from Aug 24, 2023

Conversation

shobhitagarwal1612
Copy link
Member

@shobhitagarwal1612 shobhitagarwal1612 commented Aug 20, 2023 •
edited

Towards #1581
Towards #1691

  • Removes remaining unused references to RxFirebase dependency
  • Cleanup dead code
  • Remove gradle dependency for RxFirebase. All references have been migrated to coroutines.

@gino-m @JSunde PTAL?

@shobhitagarwal1612 shobhitagarwal1612 marked this pull request as draft August 20, 2023 07:26
@shobhitagarwal1612 shobhitagarwal1612 mentioned this pull request Aug 20, 2023
Merged
@shobhitagarwal1612 shobhitagarwal1612 changed the title Cleanup remote storage #3 Cleanup remote storage Aug 20, 2023
@shobhitagarwal1612 shobhitagarwal1612 marked this pull request as ready for review August 23, 2023 04:31
@shobhitagarwal1612
Copy link
Member Author

/gcbrun

@gino-m This is now ready for a review!

@shobhitagarwal1612 shobhitagarwal1612 changed the title #3 Cleanup remote storage #3 Remove remaining references of RxFirestore from remote storage Aug 23, 2023
gino-m
gino-m approved these changes Aug 24, 2023
View reviewed changes
Copy link
Collaborator

@gino-m gino-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

W00t! 🥳

@gino-m gino-m merged commit f40c821 into google:master Aug 24, 2023
2 checks passed
@shobhitagarwal1612 shobhitagarwal1612 deleted the cleanup-remote-storage branch August 24, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gino-m gino-m gino-m approved these changes

@JSunde JSunde Awaiting requested review from JSunde

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Ground
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shobhitagarwal1612 @gino-m