Refactor a common InstructionsDialog class and ensure Drop Pin tasks … #2349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…have instructions.
shobhitagarwal1612
approved these changes
Mar 14, 2024
.../main/java/com/google/android/ground/ui/datacollection/tasks/point/DropPinTaskMapFragment.kt
Outdated
Show resolved
Hide resolved
shobhitagarwal1612
added a commit
to shobhitagarwal1612/ground-android
that referenced
this pull request
Mar 14, 2024
The references were removed in google#2349
shobhitagarwal1612
added a commit
that referenced
this pull request
Mar 14, 2024
The references were removed in #2349
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2315
Factors out the
InstructionsDialogfromCaptureLocationTaskFragmentand implements it on theDropPinTaskFragment.InstructionsDialog, which displays a standardizedAlertDialog.PTAL @shobhitagarwal1612 @gino-m !