New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add button to switch map type #406
Conversation
Invert if conditions for simplification
Thanks for the change! Is there any background on why this is needed or preferred? Before starting a change please make sure there's an Issue filed so we can discuss, since we need to consider all the different ongoing feature development and how they'll fit together. Note that we're using the [] before the PRs and Issues to indicate which feature/subarea of the app is being changes, not the type of PR/issue. |
Sorry for being so impatient. I remember asking for this feature in hangouts some days ago and you replied that it would be somewhat similar to Google Maps. Point noted for future issues. Points regarding use cases:
Done |
gnd/src/main/java/com/google/android/gnd/ui/map/gms/GoogleMapsMapProvider.java
Outdated
Show resolved
Hide resolved
No worries. We'd normally want to discuss such a change more in depth with UX Designers (@coreyleamon fyi), but since we know we'll need to have a layer switcher eventually to control offline imagery let's keep this change and iterate on it as we get more clarity. Over to @scolsen for review! |
gnd/src/main/java/com/google/android/gnd/ui/home/mapcontainer/MapContainerFragment.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, just a few final changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments as FYIs but otherwise LGTM
gnd/src/main/java/com/google/android/gnd/ui/home/mapcontainer/MapContainerViewModel.java
Outdated
Show resolved
Hide resolved
gnd/src/main/java/com/google/android/gnd/ui/home/mapcontainer/MapContainerViewModel.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small modifications, overall LGTM!
edd946d
to
a1b26df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the change!
Demo: