Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace JSON schema with proto > Firestore converter #1787

Merged
merged 16 commits into from
May 29, 2024

Conversation

gino-m
Copy link
Collaborator

@gino-m gino-m commented May 16, 2024

Implements conversion of base cases in one direction only (towards #1758) and cleans up remnants of JSON schema experiment (Closes #1698).

@gino-m gino-m force-pushed the gino-m/1758/add-proto-model branch from d21a080 to 9564d95 Compare May 16, 2024 16:07
@gino-m gino-m changed the title Implement shared lib with proto converters for web and Cloud Functions Implement proto<>Firestore converter lib May 28, 2024
@gino-m gino-m changed the title Implement proto<>Firestore converter lib Replace JSON schema with proto<>Firestore converter lib May 28, 2024
@gino-m gino-m marked this pull request as ready for review May 28, 2024 14:23
@gino-m gino-m changed the title Replace JSON schema with proto<>Firestore converter lib Replace JSON schema with proto > Firestore converter May 28, 2024
@rfontanarosa rfontanarosa merged commit a70d36d into master May 29, 2024
5 checks passed
@rfontanarosa rfontanarosa deleted the gino-m/1758/add-proto-model branch May 29, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Code health] Remove unused JSON schema codegen logic
2 participants