Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Add missing dep causing Chrome/Puppeteer testing breakage #453

Merged
merged 3 commits into from
Sep 14, 2020
Merged

[CI] Add missing dep causing Chrome/Puppeteer testing breakage #453

merged 3 commits into from
Sep 14, 2020

Conversation

gino-m
Copy link
Collaborator

@gino-m gino-m commented Sep 14, 2020 •
edited

Fixes #454.

@gino-m gino-m changed the title [DO NOT MERGE] Testing Kaniko cache breakage [CI] Fix Chrome/Puppeteer testing breakage Sep 14, 2020
@gino-m gino-m changed the title [CI] Fix Chrome/Puppeteer testing breakage [CI] Add missing dep causing Chrome/Puppeteer testing breakage Sep 14, 2020
parulraheja98
parulraheja98 approved these changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@parulraheja98 parulraheja98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHIP IT

@gino-m gino-m merged commit d8a2a25 into google:master Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parulraheja98 parulraheja98 parulraheja98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI] Chrome/Puppeteer testing broken in GCB
2 participants
@gino-m @parulraheja98