This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
Start implement string slicing #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trotterdylan
suggested changes
Jan 10, 2017
| @@ -201,20 +201,38 @@ func strGE(f *Frame, v, w *Object) (*Object, *BaseException) { | |||
| return strCompare(v, w, False, True, True), nil | |||
| } | |||
|
|
|||
| // strGetItem returns a slice of string | |||
There was a problem hiding this comment.
Please wrap comments at 80 chars
There was a problem hiding this comment.
@trotterdylan, fixed that, and also added unicode slicing, should I use separate PR?
There was a problem hiding this comment.
@S-YOU No, it's fine to leave it all in one PR. Thanks!
trotterdylan
approved these changes
Jan 10, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #77. Once this is ok, I could continue unicode.