Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pro-guard issue #713

Closed
TonyTangAndroid opened this issue Oct 16, 2015 · 4 comments
Closed

Pro-guard issue #713

TonyTangAndroid opened this issue Oct 16, 2015 · 4 comments
Assignees

Comments

@TonyTangAndroid
Copy link

I don't believe that the following code snippets should be added in the proguard.cfg.

-keep public class * {
public protected *;
}

It will cause all methods will included.

@JakeWharton
Copy link
Contributor

Who told you to add it?

@TonyTangAndroid
Copy link
Author

Sorry, I had thought that I added the link. The code is from the following link between Line 66 to 68:

https://github.com/google/gson/blob/master/examples/android-proguard-example/proguard.cfg

As it is from official example, it could be misleading for beginners. And I did not pay attention to it when I was copying the pro guard snippet.

@JakeWharton
Copy link
Contributor

Ah, ok. I looked in a few places but couldn't find it! Yeah we should get that changed.

@TonyTangAndroid
Copy link
Author

Good to know that. Thank you very much for getting back to this issue so quickly.

@inder123 inder123 self-assigned this Oct 18, 2015
sebasjm pushed a commit to sebasjm/gson that referenced this issue Mar 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@JakeWharton @inder123 @TonyTangAndroid and others