Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor FieldNamingPolicy.upperCaseFirstLetter #1515

Merged
merged 1 commit into from Apr 26, 2019

Conversation

@Degubi
Copy link
Contributor

commented Apr 17, 2019

-Refactor upperCaseFirstLetter in FieldNamingPolicy.
-Add some comments for special case handling
-Add additional test field to keep 100% coverage (branch in loop for checking to not go out of bounds).
-Shorter, faster. Except for the newly added case. I hope no one writes fields without letters.

Benchmark code: https://pastebin.com/63VJWF03
Benchmark run: https://pastebin.com/su29iePu

@googlebot googlebot added the cla: yes label Apr 17, 2019

@inder123 inder123 self-assigned this Apr 26, 2019

@inder123 inder123 merged commit 63ee47c into google:master Apr 26, 2019

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Degubi Degubi deleted the Degubi:fieldnaming_refactor branch Apr 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.