Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support strict mode for JsonParser #2648

Merged
merged 2 commits into from Mar 19, 2024

Conversation

Marcono1234
Copy link
Collaborator

Purpose

Support strict parsing for JsonParser

Description

Since the Strictness API (#2323) has not been released yet, we can fix the parsing of JsonParser in the same backward compatible way we fixed it for the Gson methods:

  • If the strictness is LEGACY_STRICT (the default) we parse with LENIENT
  • But if the user has explicitly set STRICT (which will only be possible now with the Strictness API) we respect this setting and parse in strict mode

This pull request also changes the getStrictness() == Strictness.LEGACY_STRICT checks in Gson to make the intention clearer that this is for backward compatibility. Behavior-wise they still act like before:

  • LENIENT -> LENIENT (but is not explicitly overwritten anymore now)
  • LEGACY_STRICT -> LENIENT
  • STRICT -> STRICT

Checklist

  • New code follows the Google Java Style Guide
    This is automatically checked by mvn verify, but can also be checked on its own using mvn spotless:check.
    Style violations can be fixed using mvn spotless:apply; this can be done in a separate commit to verify that it did not cause undesired changes.
  • If necessary, new public API validates arguments, for example rejects null
  • New public API has Javadoc
    • Javadoc uses @since $next-version$
      ($next-version$ is a special placeholder which is automatically replaced during release)
  • If necessary, new unit tests have been added
    • Assertions in unit tests use Truth, see existing tests
    • No JUnit 3 features are used (such as extending class TestCase)
    • If this pull request fixes a bug, a new test was added for a situation which failed previously and is now fixed
  • mvn clean verify javadoc:jar passes without errors

Copy link
Member

@eamonnmcmanus eamonnmcmanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I'm glad you thought of this before we had frozen the new API.

Just one tiny formatting concern.

gson/src/main/java/com/google/gson/Gson.java Outdated Show resolved Hide resolved
@eamonnmcmanus eamonnmcmanus merged commit 342d600 into google:main Mar 19, 2024
11 checks passed
@Marcono1234 Marcono1234 deleted the marcono1234/JsonParser-strict branch March 19, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants