Support strict mode for JsonParser
#2648
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Support strict parsing for
JsonParser
Description
Since the
Strictness
API (#2323) has not been released yet, we can fix the parsing ofJsonParser
in the same backward compatible way we fixed it for theGson
methods:LEGACY_STRICT
(the default) we parse withLENIENT
STRICT
(which will only be possible now with theStrictness
API) we respect this setting and parse in strict modeThis pull request also changes the
getStrictness() == Strictness.LEGACY_STRICT
checks inGson
to make the intention clearer that this is for backward compatibility. Behavior-wise they still act like before:LENIENT
->LENIENT
(but is not explicitly overwritten anymore now)LEGACY_STRICT
->LENIENT
STRICT
->STRICT
Checklist
This is automatically checked by
mvn verify
, but can also be checked on its own usingmvn spotless:check
.Style violations can be fixed using
mvn spotless:apply
; this can be done in a separate commit to verify that it did not cause undesired changes.null
@since $next-version$
(
$next-version$
is a special placeholder which is automatically replaced during release)TestCase
)mvn clean verify javadoc:jar
passes without errors