Skip to content

Commit

Permalink
build: test on node 18
Browse files Browse the repository at this point in the history
  • Loading branch information
tonycoco committed Mar 22, 2024
1 parent 2c248d3 commit 374d151
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 15 deletions.
12 changes: 6 additions & 6 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
on:
push:
branches: [ $default-branch ]
branches: [$default-branch]
pull_request:
name: ci
jobs:
Expand All @@ -9,7 +9,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node: [14, 16, 18]
node: [18, 20, 21]
steps:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4
- uses: actions/setup-node@v4
Expand All @@ -29,7 +29,7 @@ jobs:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4
- uses: actions/setup-node@v4
with:
node-version: 16
node-version: 18
- run: npm ci
- run: npm run system-test
system_test:
Expand All @@ -38,7 +38,7 @@ jobs:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4
- uses: actions/setup-node@v4
with:
node-version: 16
node-version: 18
- run: npm ci
- run: npm run system-test
lint:
Expand All @@ -47,7 +47,7 @@ jobs:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4
- uses: actions/setup-node@v4
with:
node-version: 16
node-version: 18
- run: npm ci
- run: npm run lint
license_check:
Expand All @@ -56,6 +56,6 @@ jobs:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4
- uses: actions/setup-node@v4
with:
node-version: 16
node-version: 18
- run: npm ci
- run: npm run license-check
2 changes: 1 addition & 1 deletion .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4
- uses: actions/setup-node@v4
with:
node-version: 16
node-version: 18
registry-url: 'https://wombat-dressing-room.appspot.com'
- run: npm ci
- run: npm publish
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 2 additions & 7 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,9 @@
"fix": "eslint --fix '**/*.ts'"
},
"engines": {
"node": ">=14"
"node": ">=18"
},
"keywords": [
"typescript",
"linter",
"formatter",
"google"
],
"keywords": ["typescript", "linter", "formatter", "google"],
"author": "Google Inc.",
"license": "Apache-2.0",
"dependencies": {
Expand Down

0 comments on commit 374d151

Please sign in to comment.