Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: minor cleanup #170

Merged
merged 1 commit into from Jun 8, 2018
Merged

test: minor cleanup #170

merged 1 commit into from Jun 8, 2018

Conversation

ofrobots
Copy link
Contributor

@ofrobots ofrobots commented Jun 8, 2018

Obsessive compulsive.

@codecov-io
Copy link

Codecov Report

Merging #170 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #170      +/-   ##
==========================================
- Coverage   97.23%   97.21%   -0.03%     
==========================================
  Files          10       10              
  Lines         398      395       -3     
  Branches       28       28              
==========================================
- Hits          387      384       -3     
  Misses         11       11
Impacted Files Coverage Δ
test/test-clean.ts 100% <100%> (ø) ⬆️
test/test-format.ts 100% <100%> (ø) ⬆️
test/test-lint.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a1bfdd...9dd605c. Read the comment docs.

@ofrobots
Copy link
Contributor Author

ofrobots commented Jun 8, 2018

TBR=@jinwoo

@ofrobots ofrobots merged commit a34ca31 into google:master Jun 8, 2018
@ofrobots ofrobots deleted the await-fixtures branch June 8, 2018 21:53
Copy link
Member

@jinwoo jinwoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I prefer having async/await even though they are redundant. That's because it makes it easy to know there's async stuff going on there without looking up the return type of withFixtures. But that's a personal preference. So LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants