Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: stop testing on Node 6 #256

Merged
merged 1 commit into from Feb 2, 2019
Merged

build: stop testing on Node 6 #256

merged 1 commit into from Feb 2, 2019

Conversation

ofrobots
Copy link
Contributor

NOTE: this targets the next branch.

@ofrobots ofrobots changed the base branch from master to next January 31, 2019 23:46
@codecov-io
Copy link

Codecov Report

Merging #256 into next will decrease coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             next     #256      +/-   ##
==========================================
- Coverage   98.54%   98.29%   -0.25%     
==========================================
  Files          12       12              
  Lines         823      823              
  Branches       69       69              
==========================================
- Hits          811      809       -2     
- Misses         12       14       +2
Impacted Files Coverage Δ
test/test-kitchen.ts 97.8% <0%> (-2.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7738ba5...286b402. Read the comment docs.

Copy link
Collaborator

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just leaving a nah here so we don't merge this until april though.

Copy link
Collaborator

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am terrible at reading.

@ofrobots ofrobots merged commit 10fe63f into google:next Feb 2, 2019
@ofrobots ofrobots deleted the no-test-v6 branch February 2, 2019 00:09
@ofrobots ofrobots mentioned this pull request Feb 6, 2019
ofrobots added a commit that referenced this pull request Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants