-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: warn when clang-format fails #62
Conversation
Odd that travis wasn't launched for this. |
@ofrobots Probably because it's unmergeable... rebased |
LGTM: provided the tests pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if the coverage impact is positive.
Codecov Report
@@ Coverage Diff @@
## master #62 +/- ##
==========================================
+ Coverage 99.58% 99.59% +0.01%
==========================================
Files 8 8
Lines 241 249 +8
Branches 8 10 +2
==========================================
+ Hits 240 248 +8
Misses 1 1
Continue to review full report at Codecov.
|
When landing, make sure the commit includes the 'Fixes: #60' metadata. |
Since the approvals were issued, I added a test... was able to get code coverage to increase by 0.01% A point of possible contention is here. The explanation is that Also, two things happened:
@DominicKramer @ofrobots PTAL at the two linked things. |
test/test-kitchen.ts
Outdated
const renamep = pify(fs.rename); | ||
const ncpp = pify(ncp.ncp); | ||
|
||
const execp = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This deserves a comment. Also, we should probably look for an ecosystem module for execp.
Rule of thumb: if you have explain why some code is the way it is in the PR, you probably also need it as a comment. LGTM once that is addressed. |
No description provided.