BREAKING CHANGE: chore: sync with internal lint #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This synchronizes the lint rules to be closer to the lint rules used internally at Google. Not all rules are available externally, so this is not *exactly* the same. Also updated the TypeScript version to 2.6.1. A fair number of new lint rules are being applied now, which means that the code will be alot more consistent with other Google code, but it also means that users of gts may need to modify the source to pick up this release. For most of the new lint rules, a fixer is also available which should help with migration. TypeScript 2.6.x enables contravariant types for function parameters, which may also require some changes. See [1] for more info. [1] https://blogs.msdn.microsoft.com/typescript/2017/10/31/announcing-typescript-2-6/
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
======================================
Coverage 99.6% 99.6%
======================================
Files 8 8
Lines 254 254
Branches 10 10
======================================
Hits 253 253
Misses 1 1
Continue to review full report at Codecov.
|
jinwoo
approved these changes
Nov 6, 2017
| {"name": "Array", "message": "tsstyle#array-constructor"} | ||
| ], | ||
| "ban-types": [true, | ||
| ["Object", "Use {} instead."], |
There was a problem hiding this comment.
What's the rationale for this rule? Just curious.
There was a problem hiding this comment.
+1, as a reader I prefer Object
There was a problem hiding this comment.
There was a problem hiding this comment.
tslint.json
Outdated
| "ban-keywords", | ||
| "allow-leading-underscore", | ||
| "allow-trailing-underscore" | ||
| ] | ||
| } | ||
| } |
kjin
approved these changes
Nov 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This synchronizes the lint rules to be closer to the lint rules used
internally at Google. Not all rules are available externally, so this
is not exactly the same.
Also updated the TypeScript version to 2.6.1.
A fair number of new lint rules are being applied now, which means that
the code will be alot more consistent with other Google code, but it
also means that users of gts may need to modify the source to pick up
this release. For most of the new lint rules, a fixer is also available
which should help with migration.
TypeScript 2.6.x enables contravariant types for function parameters,
which may also require some changes. See [1] for more info.
[1] https://blogs.msdn.microsoft.com/typescript/2017/10/31/announcing-typescript-2-6/