Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete local copies of LongAdder/Striped64 in favor of java.util.concurrent.atomic.LongAdder #3183

Open
mjd507 opened this issue Jun 15, 2018 · 2 comments
Open

Delete local copies of LongAdder/Striped64 in favor of java.util.concurrent.atomic.LongAdder #3183

mjd507 opened this issue Jun 15, 2018 · 2 comments
Assignees
@lowasser
Labels
P3 package=cache platform=java8 status=triaged type=enhancement Make an existing feature better

Comments

@mjd507
Copy link

mjd507 commented Jun 15, 2018 •
edited

in the package com.google.common.hash and com.google.common.cache,
some files like LongAddable, LongAddables, LongAdder, and Striped64 are the same.
@mjd507 mjd507 changed the title find two same Striped64.java files in guava, is this intentional ? Find some same files in guava , is this intentional ? Jun 15, 2018
@kluever
Copy link
Member

kluever commented Jun 15, 2018

Yep, we don't want them to be public APIs, so the only way to use them in both packages is to make 2 copies.

What I didn't realize is that LongAdder actually made its way into Java8. I suspect we can delete our copies of Striped64 and LongAdder in our Java8 branch. @lowasser ?

@kluever kluever changed the title Find some same files in guava , is this intentional ? Delete local copies of LongAdder/Striped64 in favor of java.util.concurrent.atomic.LongAdder Jun 15, 2018
@lowasser
Copy link
Contributor

I think this would break GWT/J2CL.

@raghsriniv raghsriniv added the P3 label Jun 24, 2019
@cpovirk cpovirk mentioned this issue Nov 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lowasser lowasser

Labels
P3 package=cache platform=java8 status=triaged type=enhancement Make an existing feature better
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@cgdecker @lowasser @kluever @mjd507 @raghsriniv