Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

com.google.common.util.concurrent.Executors should be renamed to Executors2 #8

Closed
gissuebot opened this issue Oct 31, 2014 · 6 comments
Assignees
Labels
status=fixed type=defect Bug, not working as expected

Comments

@gissuebot
Copy link

Original issue created by cky944 on 2009-11-13 at 04:26 PM


Given that the functionality of com.google.common.util.concurrent.Executors
is (from my inspection, anyway) supposed to complement that of
java.util.concurrent.Executors, it's reasonable to expect to import both
classes together.

Thus, in order to reduce import conflicts, using a name like Executors2
should be considered, in line with how Google Collections has a
Collections2 that complements java.util.Collections.

@gissuebot
Copy link
Author

Original comment posted by kevinb@google.com on 2010-01-05 at 07:41 PM


You're absolutely right; this has always bothered me, but it slipped my mind.


Status: Accepted

@gissuebot
Copy link
Author

Original comment posted by kurt.kluever on 2010-04-07 at 03:43 PM


The plan is to rename this com.google.common.util.concurrent.MoreExecutors


Owner: kurt.kluever

@gissuebot
Copy link
Author

Original comment posted by kevinb@google.com on 2010-04-09 at 03:59 PM


MoreExecutors added and Executors deprecated for release 3.


Status: Fixed

@gissuebot
Copy link
Author

Original comment posted by ori.schwartz on 2011-12-12 at 05:18 PM


Just curious why the naming convention for MoreExecutors differs from Collections2?

Is there a preferred convention (i.e., why not MoreCollections or Executors2)?

@gissuebot
Copy link
Author

Original comment posted by cky944 on 2011-12-12 at 06:36 PM


I presume it's because Collections2 was a naming mistake, but one that's too late to change. Of course, I'd love to hear from the horse's mouth, too. :-)

@gissuebot
Copy link
Author

Original comment posted by kak@google.com on 2011-12-12 at 06:40 PM


Yep, cky944 has it right...we sort of regret naming it Collections2, but we're stuck with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status=fixed type=defect Bug, not working as expected
Projects
None yet
Development

No branches or pull requests

2 participants