Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error reporting of ImmutableMap #988

Closed
gissuebot opened this issue Oct 31, 2014 · 5 comments
Closed

Improve error reporting of ImmutableMap #988

gissuebot opened this issue Oct 31, 2014 · 5 comments
Labels
Milestone

Comments

@gissuebot
Copy link

Original issue created by Ash2kk on 2012-05-02 at 11:07 AM


It can be easier to debug a little if Guava provided key of the value in the error message in ImmutableMap.entryOf() (and other such places).

java.lang.NullPointerException: null value
        at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:208)
        at com.google.common.collect.ImmutableMap.entryOf(ImmutableMap.java:144)
        at com.google.common.collect.ImmutableMap.copyOf(ImmutableMap.java:292)

@gissuebot
Copy link
Author

Original comment posted by wasserman.louis on 2012-05-02 at 02:08 PM


That particular change is easy enough, I think -- we just add a message to checkNotNull.


Labels: Type-Defect, Package-Collect

@gissuebot
Copy link
Author

Original comment posted by gak@google.com on 2012-05-10 at 06:44 PM


(No comment entered for this change.)


Status: Fixed
Labels: Milestone-Release13

@gissuebot
Copy link
Author

Original comment posted by Ash2kk on 2012-07-18 at 08:00 AM


public static <K, V> ImmutableMap<K, V> of(K k1, V v1) was not fixed.

@gissuebot
Copy link
Author

Original comment posted by cpovirk@google.com on 2012-07-19 at 08:03 PM


(No comment entered for this change.)


Status: Accepted

@gissuebot
Copy link
Author

Original comment posted by cpovirk@google.com on 2012-07-24 at 12:27 AM


Thanks for catching our oversight.

cc36cde


Status: Fixed
Labels: Milestone-Release14

@cgdecker cgdecker modified the milestones: 13.0, 14.0 Nov 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants