Clarify we're wrapping exceptions with InvocationTargetException to m…

…atch JDK reflection behaviour
google · Jun 6, 2020 · 1386c48 · 1386c48
1 parent 6f29cde
commit 1386c48
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/core/src/com/google/inject/internal/DefaultConstructionProxyFactory.java b/core/src/com/google/inject/internal/DefaultConstructionProxyFactory.java
@@ -81,7 +81,7 @@ public T newInstance(Object... arguments) throws InvocationTargetException {
       try {
         return (T) fastConstructor.apply(null, arguments);
       } catch (Throwable e) {
-        throw new InvocationTargetException(e);
+        throw new InvocationTargetException(e); // match JDK reflection behaviour
       }
     }
 

diff --git a/core/src/com/google/inject/internal/ProviderMethod.java b/core/src/com/google/inject/internal/ProviderMethod.java
@@ -257,12 +257,11 @@ private static final class FastClassProviderMethod<T> extends ProviderMethod<T>
 
     @SuppressWarnings("unchecked")
     @Override
-    public T doProvision(Object[] parameters)
-        throws IllegalAccessException, InvocationTargetException {
+    public T doProvision(Object[] parameters) throws InvocationTargetException {
       try {
         return (T) fastMethod.apply(instance, parameters);
       } catch (Throwable e) {
-        throw new InvocationTargetException(e);
+        throw new InvocationTargetException(e); // match JDK reflection behaviour
       }
     }
   }

diff --git a/core/src/com/google/inject/internal/SingleMethodInjector.java b/core/src/com/google/inject/internal/SingleMethodInjector.java
@@ -46,11 +46,11 @@ private MethodInvoker createMethodInvoker(final Method method) {
         return new MethodInvoker() {
           @Override
           public Object invoke(Object target, Object... parameters)
-              throws IllegalAccessException, InvocationTargetException {
+              throws InvocationTargetException {
             try {
               return fastMethod.apply(target, parameters);
             } catch (Throwable e) {
-              throw new InvocationTargetException(e);
+              throw new InvocationTargetException(e); // match JDK reflection behaviour
             }
           }
         };