Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When will Guice support Java 16? #1521

Closed
danielalmeidagoncalves opened this issue May 27, 2021 · 5 comments
Closed

When will Guice support Java 16? #1521

danielalmeidagoncalves opened this issue May 27, 2021 · 5 comments

Comments

@danielalmeidagoncalves
Copy link

Hi all,

Reading the latest Guice release (5.0.1), now Guice supports java15. What are the plans to support java16? In our project we would like to do the upgrade but we depend on Guice to do the migration.

Thanks in advance!

@GedMarc
Copy link

GedMarc commented Jun 2, 2021

You can use GuicedEE for JVM modular Guice on all JDK modules,

https://guicedee.com

@virustotalop
Copy link

virustotalop commented Jun 3, 2021

From my preliminary testing it looks like 5.0.1 may work on java 16 but I'm not sure about your specific use case. I looked at the pom.xml for 5.0.1 and it looks like it is using asm 9.1 which supports up to java 17 https://asm.ow2.io/versions.html.

@maxim5
Copy link

maxim5 commented Aug 18, 2021

One notable java 16 feature worth better support is records. For example, the following does not work in Guice right now, though I don't see reasons why it shouldn't:

public record Foo(@Inject Bar bar) {
  ...
}

@Kurru
Copy link

Kurru commented Nov 17, 2022

version 5.1 supports Java 17, so perhaps that's enough? https://github.com/google/guice/wiki/Guice510

@wendigo
Copy link

wendigo commented Nov 18, 2022

In https://github.com/trinodb/trino we are using Guice 5.1.0 since we've switched to JDK 17 in August. Since then, we've released 20+ versions of the software, and we've never encountered any incompatibilities between Guice and JDK17. JDK16 introduced strong module encapsulation by default, so if Guice works in JDK17, I'd expect it to work in 16 as well.

copybara-service bot pushed a commit that referenced this issue Apr 14, 2023
Fixes #1671
Fixes #1657
Fixes #1654
Fixes #1521
Fixes #1256

PiperOrigin-RevId: 524360975
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants