Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JpaPersistService does not allow nested UnitOfWork #1555

Open
edechter opened this issue Dec 14, 2021 · 1 comment
Open

JpaPersistService does not allow nested UnitOfWork #1555

edechter opened this issue Dec 14, 2021 · 1 comment

Comments

@edechter
Copy link

JpaPersistService's implementation of UnitOfWork::begin looks like it throws an exception if called within an existing UnitOfWork:

"Work already begun on this thread. Looks like you have called UnitOfWork.begin() twice"

But the interface JavaDoc says that this should be okay:

* already one open, the invocation will do nothing. In this way, you can define arbitrary
.

Is this an error?

crizzis added a commit to crizzis/guice that referenced this issue Feb 22, 2022
crizzis added a commit to crizzis/guice that referenced this issue Feb 23, 2022
crizzis added a commit to crizzis/guice that referenced this issue Feb 23, 2022
@crizzis
Copy link

crizzis commented Feb 23, 2022

I just created a PR solving this issue and adjusting the logic behind nested transactions as well.

The CI build is stuck at the CLA step, even though I have been added to the CLA by my organization. Kindly requesting a status update on the CLA processing for Digital New Agency.

EDIT problem solved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants