Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support @Nullable annoations marked with @Target({TYPE_USE}) #1311

Closed
wants to merge 1 commit into from

Conversation

nresare
Copy link

@nresare nresare commented Apr 9, 2020

Java support for annotation metadata has evolved, and projects providing
implementations of @nullable has been adopting those new features. This
has had the side effect of some commonly used @nullable annotations not
working as expected with Guice. This change uses reflection to extract
new style @nullable annotations as well as old style ones. Addresses
the issue described in #1193

Java support for annotation metadata has evolved, and projects providing
implementations of @nullable has been adopting those new features. This
has had the side effect of some commonly used @nullable annotations not
working as expected with Guice. This change uses reflection to extract
new style @nullable annotations as well as old style ones. Addresses
the issue described in google#1193
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@nresare
Copy link
Author

nresare commented Apr 9, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Apr 9, 2020
@cpovirk
Copy link
Member

cpovirk commented Jan 25, 2021

1a410a8 has done some work for type annotations. That may be sufficient for your needs (though I don't believe there's been a release yet).

@sameb
Copy link
Member

sameb commented Apr 19, 2023

Indeed that commit already fixed this.

@sameb sameb closed this Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants