Add support for jakarta.inject to core Guice. #1711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
changed the title
toProvider(...) to instances of jakarta.inject.Provider or classes/keys/typeLiterals of type jakarta.inject.Provider. See https://github.com/google/guice/issues/1383#issuecomment-1523410855 for details of the plans. The Guice 6.0 release will support javax.inject _and_ jakarta.inject (excluding toProvider() support for jakarta.inject), and the Guice 7.0+ release will remove the javax.inject references.
copybara-service
bot
force-pushed
the
test_526763665
branch
4 times, most recently
from
c9c7d4e
to
b0ea875
Compare
This does not add support for `toProvider(...)` to instances of `jakarta.inject.Provider` or classes/keys/typeLiterals of type `jakarta.inject.Provider`. See #1383 (comment) for details of the plans. The Guice 6.0 release will support `javax.inject` _and_ `jakarta.inject` (excluding `toProvider()` support for `jakarta.inject`), and the Guice 7.0+ release will remove the `javax.inject` references. Further background on these issues: * #1630 * #1679 * #1490 * #1383 PiperOrigin-RevId: 527349023
copybara-service
bot
force-pushed
the
test_526763665
branch
from
b0ea875
to
5eff2ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for jakarta.inject to core Guice.
This does not add support for
toProvider(...)to instances ofjakarta.inject.Provideror classes/keys/typeLiterals of typejakarta.inject.Provider. See #1383 (comment) for details of the plans. The Guice 6.0 release will supportjavax.injectandjakarta.inject(excludingtoProvider()support forjakarta.inject), and the Guice 7.0+ release will remove thejavax.injectreferences.Further background on these issues: