Implement and and or in Matcher directly
#1716
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm a little concerned that removing the overrides from AbstractMatcher will break binary compatibility with old jars that delegate to AbstractMatcher.{and,or}. WDYT of keeping those overrides (even though they're redundant on the source-code level)? Marking as @deprecated SGTM, with the javadoc explaining how implementing Matcher is enough (because of the default |
kashike
force-pushed
the
feature/and-or-matchers
branch
from
6965a27
to
d1d6322
Compare
|
@sameb Sounds good - changes made. Let me know if that looks good now. |
sameb
approved these changes
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1177
This makes
AbstractMatcheritself empty now - do you want it to be marked as deprecated?