Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup #10388

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+0 −16
Open

Cleanup #10388

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 0 additions & 16 deletions test/syscalls/linux/proc_net.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,9 +224,6 @@ PosixErrorOr<uint64_t> GetSNMPMetricFromProc(const std::string snmp,
TEST(ProcNetSnmp, TcpReset) {
SKIP_IF(IsRunningWithHostinet());

// TODO(gvisor.dev/issue/866): epsocket metrics are not savable.
DisableSave ds;

uint64_t oldAttemptFails;
uint64_t oldActiveOpens;
uint64_t oldOutRsts;
Expand Down Expand Up @@ -281,9 +278,6 @@ TEST(ProcNetSnmp, TcpEstab) {
// statistics have noise.
SKIP_IF(GetMibsAllocationSysctl() == 0);

// TODO(gvisor.dev/issue/866): epsocket metrics are not savable.
DisableSave ds;

uint64_t oldEstabResets;
uint64_t oldActiveOpens;
uint64_t oldPassiveOpens;
Expand Down Expand Up @@ -377,9 +371,6 @@ TEST(ProcNetSnmp, TcpEstab) {
TEST(ProcNetSnmp, UdpNoPorts) {
SKIP_IF(IsRunningWithHostinet());

// TODO(gvisor.dev/issue/866): epsocket metrics are not savable.
DisableSave ds;

uint64_t oldOutDatagrams;
uint64_t oldNoPorts;
auto snmp = ASSERT_NO_ERRNO_AND_VALUE(GetContents("/proc/net/snmp"));
Expand Down Expand Up @@ -420,9 +411,6 @@ TEST(ProcNetSnmp, UdpNoPorts) {
TEST(ProcNetSnmp, UdpIn) {
SKIP_IF(IsRunningWithHostinet());

// TODO(gvisor.dev/issue/866): epsocket metrics are not savable.
const DisableSave ds;

uint64_t oldOutDatagrams;
uint64_t oldInDatagrams;
auto snmp = ASSERT_NO_ERRNO_AND_VALUE(GetContents("/proc/net/snmp"));
Expand Down Expand Up @@ -550,10 +538,6 @@ TEST(ProcSysNetIpv4Recovery, Exists) {
}

TEST(ProcSysNetIpv4Recovery, CanReadAndWrite) {
// TODO(b/162988252): Enable save/restore for this test after the bug is
// fixed.
DisableSave ds;

SKIP_IF(!ASSERT_NO_ERRNO_AND_VALUE(HaveCapability((CAP_NET_ADMIN))) ||
IsRunningWithHostinet());

Expand Down