Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netstack: don't count PMTUD when detecting loss #10409

Merged
merged 1 commit into from
May 15, 2024
Merged

netstack: don't count PMTUD when detecting loss #10409

merged 1 commit into from
May 15, 2024

Commits on May 15, 2024

  1. netstack: don't count PMTUD when detecting loss 

    Throughput could be lowered by entering fast recovery unnecessarily. When a
larger-than-MTU segment was retransmitted as multiple segments, loss detection
could fire either because we hit the dupack threshold or RACK detected loss due
to ACKs from retransmissions.

RACK was more succeptible to this because it's better at detecting loss and can
do so even without 3 dupacks. Thus it fell into this trap more often.

Addresses #10344.

PiperOrigin-RevId: 634071568
    @kevinGC @gvisor-bot
    kevinGC authored and gvisor-bot committed May 15, 2024
    Configuration menu
    Copy the full SHA
    fe4459d View commit details
    Browse the repository at this point in the history