Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix EOF (^D) handling in devpts (partially addr #9333) #9338

Closed
wants to merge 0 commits into from
Closed

Fix EOF (^D) handling in devpts (partially addr #9333) #9338

wants to merge 0 commits into from

Conversation

copybara-service[bot]
Copy link

@copybara-service copybara-service bot commented Sep 5, 2023 •
edited
Loading

Fix EOF (^D) handling in devpts (partially addr #9333)

This fixes the ctrl-d part of #9333.

Disclaimer: new to this codebase.
FUTURE_COPYBARA_INTEGRATE_REVIEW=#9336 from thundergolfer:jonathon/dev-pts-eof-handling e8c399a

@copybara-service copybara-service bot added the exported Issue was exported automatically label Sep 5, 2023
@copybara-service copybara-service bot force-pushed the test/cl562795982 branch 3 times, most recently from 845da9d to 073afa4 Compare September 5, 2023 17:39
@nlacasse
Copy link
Collaborator

nlacasse commented Sep 5, 2023

This seems to break the PtyTest.TermiosONLCR test:

[ RUN      ] PtyTest.TermiosONLCR
test/syscalls/linux/pty.cc:466: Failure
Value of: ReadFd(fd.get(), &c, 1)
Expected: -1 (failure), with errno PosixError(errno=11 Resource temporarily unavailable)
  Actual: 0 (of type long)
[  FAILED  ] PtyTest.TermiosONLCR (5 ms)

Full logs here

@copybara-service copybara-service bot force-pushed the test/cl562795982 branch 10 times, most recently from 7c439a7 to 4956d99 Compare September 6, 2023 19:45
@copybara-service copybara-service bot closed this Sep 6, 2023
@copybara-service copybara-service bot deleted the test/cl562795982 branch September 6, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
exported Issue was exported automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@nlacasse