Handle O_PATH correctly with fchmodat(2) and utimensat(2). #9468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
changed the title
copybara-service
bot
force-pushed
the
test/cl571134499
branch
2 times, most recently
from
6b729f9
to
3165795
Compare
copybara-service
bot
force-pushed
the
test/cl571134499
branch
from
3165795
to
f3de61d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle O_PATH correctly with fchmodat(2) and utimensat(2).
setstatat() was invoking the FD-impl directly, instead of going through the
FS-impl, in hopes that open FDs can perform these operations more quickly.
However, this optimization breaks fchmodat(AT_EMPTY_PATH) for O_PATH FDs
because O_PATH FD-impl rejects SetStat() operation. So disabled this
optimization for O_PATH FDs.
O_PATH FDs via utimensat(opathFD, path=NULL). Linux disallows this as
mentioned in the patch. So fixed utimes codebase to emulate Linux accurately.
Fixes #9453