Use fully-qualified name in generated class to fix references to clas…

…ses in a different package.

Fixes #28.

eventbinder/src/main/java/com/google/web/bindery/event/gwt/rebind/binder/EventBinderGenerator.java

@@ -89,7 +89,7 @@ private SourceWriter createSourceWriter(
         new ClassSourceFileComposerFactory(packageName, simpleName);
 
     composer.setSuperclass(AbstractEventBinder.class.getCanonicalName()
-        + "<" + targetType.getName() + ">");
+        + "<" + targetType.getQualifiedSourceName() + ">");
     composer.addImplementedInterface(eventBinderType.getName());
 
     composer.addImport(EventBinder.class.getCanonicalName());

eventbinder/src/test/java/com/google/web/bindery/event/shared/binder/EventBinderTest.java

@@ -20,6 +20,7 @@
 import com.google.web.bindery.event.shared.EventBus;
 import com.google.web.bindery.event.shared.HandlerRegistration;
 import com.google.web.bindery.event.shared.SimpleEventBus;
+import com.google.web.bindery.event.shared.binder.subpackage.SomeActivity;
 
 /**
  * End-to-end test of {@link EventBinder} and associated classes.
@@ -128,8 +129,20 @@ public void testEventBinder_withHandlersInSuperclass() {
     assertEquals(2, presenter.firstAndSecondEventsHandled);
   }
 
+  // https://github.com/google/gwteventbinder/issues/28
+  public void testEventBinder_inDifferentPackage() {
+    EventBus eventBus = new SimpleEventBus();
+    TestPresenter presenter = new TestPresenter();
+    SomeActivity.SomeEventBinder binder = GWT.create(SomeActivity.SomeEventBinder.class);
+    binder.bindEventHandlers(presenter, eventBus);
+
+    // Test one event
+    assertEquals(0, presenter.firstEventsHandled);
+    eventBus.fireEvent(new FirstEvent());
+    assertEquals(1, presenter.firstEventsHandled);
+  }
 
-  static class TestPresenter {
+  public static class TestPresenter {
     interface MyEventBinder extends EventBinder<TestPresenter> {}
 
     int firstEventsHandled;
@@ -139,27 +152,27 @@ interface MyEventBinder extends EventBinder<TestPresenter> {}
     int firstEventsWithoutParameterHandled;
 
     @EventHandler
-    void onFirstEvent(FirstEvent e) {
+    public void onFirstEvent(FirstEvent e) {
       firstEventsHandled++;
     }
 
     @EventHandler
-    void onSecondEvent(SecondEvent e) {
+    public void onSecondEvent(SecondEvent e) {
       secondEventsHandled++;
     }
 
     @EventHandler
-    void onThirdEvent(ThirdEvent e) {
+    public void onThirdEvent(ThirdEvent e) {
       thirdEventsHandled++;
     }
 
     @EventHandler(handles = {FirstEvent.class, SecondEvent.class})
-    void onFirstAndSecondEvent(GenericEvent event) {
+    public void onFirstAndSecondEvent(GenericEvent event) {
       firstAndSecondEventsHandled++;
     }
 
     @EventHandler(handles = {FirstEvent.class})
-    void onFirstEventWithoutParameter() {
+    public void onFirstEventWithoutParameter() {
         firstEventsWithoutParameterHandled++;
     }
   }
@@ -177,12 +190,12 @@ void onFirstEventAgain(FirstEvent e) {
 
     @Override
     @EventHandler
-    void onSecondEvent(SecondEvent e) {
+    public void onSecondEvent(SecondEvent e) {
       subclassSecondEventsHandled++;
     }
   }
 
-  static class FirstEvent extends GenericEvent {}
-  static class SecondEvent extends GenericEvent {}
-  static class ThirdEvent extends GenericEvent {}
+  public static class FirstEvent extends GenericEvent {}
+  public static class SecondEvent extends GenericEvent {}
+  public static class ThirdEvent extends GenericEvent {}
 }

eventbinder/src/test/java/com/google/web/bindery/event/shared/binder/subpackage/SomeActivity.java

@@ -0,0 +1,9 @@
+package com.google.web.bindery.event.shared.binder.subpackage;
+
+import com.google.web.bindery.event.shared.binder.EventBinder;
+import com.google.web.bindery.event.shared.binder.EventBinderTest;
+
+/** This class exists to test that EventBinder works when referencing a class in a different package. */
+public class SomeActivity {
+  public interface SomeEventBinder extends EventBinder<EventBinderTest.TestPresenter> {}
+}