tensor_ext: adds tensor_ext.simd_encoding attribute to describe SIMD packing #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_640643896
branch
from
3bfc38d
to
a6cbd16
Compare
j2kun
approved these changes
Jun 6, 2024
AlexanderViand-Intel
requested changes
Jun 6, 2024
There was a problem hiding this comment.
I think this looks great as a starting point for better SIMD support! My only concern would be the name simd_encoding, since "encoding" is very overloaded in RLWE-style FHE. For example, people might expect this to be about how (already correctly sized) vectors of integers are converted into actual polynomials.
How about we call this attribute simd_replication/simd_mapping or something like that?
|
Or perhaps the name we use informally: packing |
I think that'd work much better than my suggestions 👍 |
copybara-service
bot
force-pushed
the
test_640643896
branch
from
a6cbd16
to
559150b
Compare
|
Name & format changed, thank you! |
asraa
added
the
pull_ready
copybara-service
bot
force-pushed
the
test_640643896
branch
from
559150b
to
6c466f1
Compare
copybara-service
bot
force-pushed
the
test_640643896
branch
from
6c466f1
to
2704331
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tensor_ext: adds tensor_ext.simd_encoding attribute to describe SIMD packing
Part of #704