bgv/openfhe: update rotation index to be an integerattr #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_644401397
branch
from
33ef205
to
90103a1
Compare
j2kun
approved these changes
Jun 20, 2024
copybara-service
bot
force-pushed
the
test_644401397
branch
3 times, most recently
from
08e83ea
to
62b2671
Compare
This change updates the rotation index / offset to be an attribute rather than an SSA value, reflecting the requirement that we must have a statically known constant rotation for the RLWE rotation operation. We can also lower uknown tensor_ext rotations like a blind rotate or PIR style operation, but that is future work if we need it. Fixes #741 I'll rebase this on top of #696 PiperOrigin-RevId: 645162459
copybara-service
bot
force-pushed
the
test_644401397
branch
from
62b2671
to
da08b01
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bgv/openfhe: update rotation index to be an integerattr
This change updates the rotation index / offset to be an attribute rather than an SSA value, reflecting the requirement that we must have a statically known constant rotation for the RLWE rotation operation.
We can also lower uknown tensor_ext rotations like a blind rotate or PIR style operation, but that is future work if we need it.
Fixes #741
I'll rebase this on top of #696