re-define insted of undef in Neon

[castigli]

Hi @jan-wassenberg, I believe there is a typo here

highway/hwy/ops/arm_neon-inl.h

Line 1589 in 330f409

#define HWY_NEON_BUILD_ARG_HWY_TESTBIT

I think it should be #undef rather then a re-defintion.

[jan-wassenberg]

Hi @castigli, oops, yes, thanks for catching this. Would you like to try sending an MR or prefer that we fix it?

[castigli]

I will try sending a MR this evening, but feel free to ignore it and fix it on your side if it is more convenient!

[jan-wassenberg]

@castigli sounds good, let's try the MR :)

[castigli]

Hi @jan-wassenberg, just a quick a update on this. I was about to submit a PR when I realized that I need to submit a CLA.
Since I am working on it not only on my free time need to check what steps I need to take on the EPFL/Blue Brain Project side in order to be able to sign the agreement.

[jan-wassenberg]

@castigli oh, right. AFAICS we do not yet have a blanket CLA for your organization. Here's some info, hope this helps?

[stefson]

hi everyone, I ran into these errors when building firefox nightly on arm with neon:

19:53.10 /usr/armv7a-unknown-linux-gnueabihf/tmp/portage/www-client/firefox-90.0/work/firefox-90.0/third_party/highway/hwy/ops/arm_neon-inl.h:876:326: error: no matching function for call to 'hwy::N_NEON::Mask128<float, 4>::Mask128(uint32x4_t)'

do you think your patch will solve this? thanks

here is the full build log, in case you're interested: firefox-90-nightly-broken-arm.patch.zip , grep for error:` to find them all

[jan-wassenberg]

@stefson thank you for reporting this. It is unrelated to this #undef; looks like GCC 9.3 for armv7 is stricter about casting vectors. I expect to have a fix for this tomorrow.

[jan-wassenberg]

@castigli I've fixed the undef as part of the fixes for stefson's report :)

[castigli]

@jan-wassenberg thank you for letting me know, I am pushing on my side to get the CLA approved. Hopefully it won't take too long!

[jan-wassenberg]

@castigli sounds good, thanks for sharing, do let me know if I can help with the process.