-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
re-define insted of undef in Neon #188
Comments
Hi @castigli, oops, yes, thanks for catching this. Would you like to try sending an MR or prefer that we fix it? |
I will try sending a MR this evening, but feel free to ignore it and fix it on your side if it is more convenient! |
@castigli sounds good, let's try the MR :) |
Hi @jan-wassenberg, just a quick a update on this. I was about to submit a PR when I realized that I need to submit a CLA. |
hi everyone, I ran into these errors when building firefox nightly on arm with neon: 19:53.10 /usr/armv7a-unknown-linux-gnueabihf/tmp/portage/www-client/firefox-90.0/work/firefox-90.0/third_party/highway/hwy/ops/arm_neon-inl.h:876:326: error: no matching function for call to 'hwy::N_NEON::Mask128<float, 4>::Mask128(uint32x4_t)' do you think your patch will solve this? thanks here is the full build log, in case you're interested: firefox-90-nightly-broken-arm.patch.zip , grep for error:` to find them all |
@stefson thank you for reporting this. It is unrelated to this |
@castigli I've fixed the undef as part of the fixes for stefson's report :) |
@jan-wassenberg thank you for letting me know, I am pushing on my side to get the CLA approved. Hopefully it won't take too long! |
@castigli sounds good, thanks for sharing, do let me know if I can help with the process. |
Hi @jan-wassenberg, I believe there is a typo here
highway/hwy/ops/arm_neon-inl.h
Line 1589 in 330f409
I think it should be
#undef
rather then a re-defintion.The text was updated successfully, but these errors were encountered: