Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fails to build on PPC non-Linux #345

Closed
jbeich opened this issue Aug 22, 2021 · 1 comment · Fixed by #346
Closed

Fails to build on PPC non-Linux #345

jbeich opened this issue Aug 22, 2021 · 1 comment · Fixed by #346

Comments

@jbeich
Copy link

jbeich commented Aug 22, 2021 •
edited
Loading

Found via libjxl package. From error log:

hwy/nanobenchmark.cc:50:10: fatal error: 'sys/platform/ppc.h' file not found
#include <sys/platform/ppc.h>  // NOLINT __ppc_get_timebase_freq
         ^~~~~~~~~~~~~~~~~~~~

See also abseil/abseil-cpp@0033c9ea91a5
@jan-wassenberg
Copy link
Member

Thank you for reporting this and sharing the link. Will have this fixed shortly by adding && defined(__GLIBC__) to the HWY_ARCH_PPC condition.

copybara-service bot pushed a commit that referenced this issue Aug 23, 2021
@jan-wassenberg
Fixes #345: PPC build for non-glibc.
806bb59 
Thanks @jbeich for reporting this.

PiperOrigin-RevId: 392356260
@copybara-service copybara-service bot mentioned this issue Aug 23, 2021
Merged
copybara-service bot pushed a commit that referenced this issue Aug 23, 2021
@jan-wassenberg
Fixes #345: PPC build for non-glibc.
8ed92bf 
Thanks @jbeich for reporting this.

PiperOrigin-RevId: 392356260
copybara-service bot pushed a commit that referenced this issue Aug 23, 2021
@jan-wassenberg
Fixes #345: PPC build for non-glibc.
86ab622 
Thanks @jbeich for reporting this.

PiperOrigin-RevId: 392356260
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #345: PPC build for non-glibc. google/highway
2 participants
@jbeich @jan-wassenberg