Updated the darwin area of the Makefile to more accurate variable nam… #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es: changed OS_VERSION to OSX_SDK_VERSION.
…version and OS X version.
|
Most of these changes are based upon @tl0gic comments to my last PR. Thanks! |
|
Hi @tl0gic - will you take this - I've already too much mess to the macos :) |
tl0gic
reviewed
Oct 15, 2016
| endif | ||
|
|
||
| ifneq (,$(findstring 10.12,$(OSX_SDK_VERSION))) | ||
| SDK_NAME := "macosx10.12" | ||
| else ifneq (,$(findstring 10.11,$(OSX_SDK_VERSION))) | ||
| # El Capitan didn't break compatibility | ||
| SDK_NAME := "macosx10.11" |
There was a problem hiding this comment.
I think we can avoid the if/else conditions here if we do something like this:
SDK_NAME := macosx$(OSX_SDK_VERSION)
What do you think?
There was a problem hiding this comment.
Yeah, def, let me give that a shot!
There was a problem hiding this comment.
@tl0gic Please take a look now; let me know what you think!
|
Hey @robertswiecki, sure thing! @aaronc100 thanks for doing this! I think overall it looks good, I left you one small comment. Let me know what you think. |
…for operating on SDK version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…es: changed OS_VERSION to OSX_SDK_VERSION.