Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make seconds optional on TimePicker #194

Merged
merged 11 commits into from
May 23, 2022
Merged

Make seconds optional on TimePicker #194

merged 11 commits into from
May 23, 2022

Conversation

JohnNichol
Copy link
Collaborator

WHAT

Make the seconds picker optional on TimePicker

WHY

Often we only want users to select the hour and minute and removing the seconds picker will make the screen clearer and easier to use

HOW

Checklist 馃搵

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • DatePickerTest is failing - but I can't see how this patch is related.
  • Update metalava's signature text files

@JohnNichol JohnNichol requested a review from yschimke May 21, 2022 10:19
yschimke
yschimke approved these changes May 21, 2022
View reviewed changes
Copy link
Collaborator

@yschimke yschimke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@JohnNichol JohnNichol merged commit f831f79 into google:main May 23, 2022
@yschimke yschimke mentioned this pull request Jun 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yschimke yschimke yschimke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JohnNichol @yschimke