Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly update the scaffoldState when the scrollstate changes. #2278

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Properly update the scaffoldState when the scrollstate changes. #2278

merged 2 commits into from
Jun 26, 2024

Conversation

Tolriq
Copy link
Contributor

@Tolriq Tolriq commented Jun 26, 2024

WHAT

Fix stalled scrollstate in screenscaffold state when updated.

WHY

HOW

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

@yschimke yschimke merged commit 43b4bf9 into google:main Jun 26, 2024
6 checks passed
@yschimke
Copy link
Collaborator

yschimke commented Jun 26, 2024 •
edited
Loading

TODO - Create a test to cover edge cases with Scaffold

#2279

@yschimke yschimke mentioned this pull request Jun 26, 2024
Open
@yschimke yschimke mentioned this pull request Jul 19, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yschimke yschimke yschimke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Tolriq @yschimke