[Tiles] Split LayoutPreview api into element/root variants. #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ataulm
commented
Jun 16, 2022
| layout: LayoutElement, | ||
| public fun LayoutElementPreview( | ||
| element: LayoutElement, | ||
| @ColorInt windowBackgroundColor: Int = Color.DKGRAY, |
There was a problem hiding this comment.
Reverted this to DKGRAY where in the issue it was BLACK.
ataulm
commented
Jun 16, 2022
| @@ -163,7 +163,7 @@ fun SampleButtonImagePreview() { | |||
| .setId("click") | |||
| .build() | |||
|
|
|||
| LayoutPreview( | |||
| LayoutElementPreview( | |||
There was a problem hiding this comment.
So previously, LayoutPreview was only suitable for small components like buttons. The equivalent new API is LayoutElementPreview.
|
The instrumentation tests can be flaky, If they are mostly passing then just land it. |
yschimke
reviewed
Jun 16, 2022
| layout: LayoutElement, | ||
| public fun LayoutElementPreview( | ||
| element: LayoutElement, | ||
| @ColorInt windowBackgroundColor: Int = Color.DKGRAY, |
There was a problem hiding this comment.
I wonder if we should actually prefer Compose colors here in the API? Thoughts? Can be a follow up if so.
yschimke
approved these changes
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Splits the
LayoutPreviewpreview API for tiles intoLayoutElementPreviewandLayoutRootPreview.WHY
The previous LayoutPreview API only worked for non-root elements, like Button. This is because the passed LayoutElement was also wrapped in a BoxLayout so that the passed element could be rendered in the center of the screen. Passing a root element (like PrimaryLayout) to this API which assumes that it has full width and height didn't work.
HOW
This PR adds two APIs, one intended for elements and one for root layouts. They're chained together, such that the element one will wrap the element in a BoxLayout (a root layout), and pass that to the root layout API.
Checklist 📋
[-] Add explicit visibility modifier and explicit return types for public declarations
[-] Run spotless check
[] Run tests
[-] Update metalava's signature text files