Change PlaceholderChip to have shimmer effect #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luizgrp
force-pushed
the
placeholderchip
branch
2 times, most recently
from
dbff509
to
ffae1e8
Compare
luizgrp
force-pushed
the
placeholderchip
branch
from
ffae1e8
to
afaee21
Compare
yschimke
approved these changes
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Change
PlaceholderChipto have shimmer effect.device-2022-10-28-162349.mp4
As per specs, the chip colors will be the same for any chip style (primary, secondary, custom).
Previews :
WHY
In order to align with Figma specs.
HOW
Use wear compose placeholder modifiers.
Checklist 📋