Add note regarding export of nested folders with Apple Mail #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnnnthnn
changed the title
eesheesh
reviewed
Apr 13, 2018
import-mailbox-to-gmail.py
Outdated
| @@ -182,7 +182,8 @@ def process_mbox_files(username, service, labels): | |||
| for root, dirs, files in os.walk(base_path): | |||
| for dir in dirs: | |||
| try: | |||
| get_label_id_from_name(service, username, labels, dir) | |||
| labelname = os.path.join(root[len(base_path) + 1:], dir) | |||
There was a problem hiding this comment.
I think you need to sync your branch - this change is already in the master branch:
eesheesh
requested changes
Apr 13, 2018
|
Not sure what happened. I was assuming this was some just a GitHub quirk. Will look into this & apologies for the extra work for you! :) |
|
No problem! :) Let me know when I should take another look. |
|
Looks like rebasing did the trick! Should only contain the right commit now. |
eesheesh
approved these changes
Apr 13, 2018
|
Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per eesheesh's suggestion in #36