Expose currentNode being patched #132
Conversation
| @@ -109,6 +110,58 @@ describe('element creation', () => { | |||
|
|
|||
| }); | |||
|
|
|||
|
|
|||
| describe('should return getCurrentNode', () => { | |||
There was a problem hiding this comment.
It seems that this should probably be a top level describe (it its own file) since currentElement is really it's own feature that also applies on updates not just element creation.
|
@markuskobler: Want to rebase and update based on the comments? I'm actually in need of this. |
markuskobler
force-pushed
the
currentnode
branch
from
223a933
to
23436f7
Compare
|
Sorry for dragging feet on this, I have been distracted with other work the last few weeks. I also added some fix's to the closure annotations which I hope are not too contentious. It is failing on |
| el = null; | ||
| }); | ||
|
|
||
| it('from elementOpen', () => { |
There was a problem hiding this comment.
its should look something like:
it('should return the element from elementOpen', ...)
describes should describe the feature
describe('currentElement', ...
Ideally, the full thing would read as a sentence, for example in element_creation.js:
"element creation when creating a single node should render with the specified tag"
Also, context isn't really a feature as far as a consumer of the library cares. The feature they deal with is just currentElement.
| @@ -61,14 +61,16 @@ var createNode = function(doc, nodeName, key, statics) { | |||
| if (nodeName === '#text') { | |||
| node = doc.createTextNode(''); | |||
| } else { | |||
| node = createElement(doc, nodeName, key, statics); | |||
| node = createElement(doc, nodeName, key); | |||
Expose currentNode being patched
While experimenting with idom I'm finding that while
var el = elementOpen('div')works it can complicated code that wants to repatch elements later. Exposing the current Element makes the code a bit more readable.Currently throws an error when not production build.