Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix go runtime specification #91

Merged
merged 2 commits into from Oct 8, 2022
Merged

Conversation

ravwojdyla
Copy link
Contributor

Otherwise make deploy fails with:

~/inverting-proxy$ make deploy
if [ -z "###" ]; then echo "You must specify the PROJECT_ID"; exit 1; fi
gcloud app deploy --project "###" --version v1 ./app/*.yaml
ERROR: (gcloud.app.deploy) Staging command [/usr/lib/google-cloud-sdk/platform/google_appengine/go-app-stager /home/rav/inverting-proxy/app/agent.yaml /home/rav/inverting-proxy/app /tmp/tmpjnzaulxz/tmpps194cax] failed with return code [1].

------------------------------------ STDOUT ------------------------------------
------------------------------------ STDERR ------------------------------------
2022/01/26 09:13:18 invalid runtime value go
--------------------------------------------------------------------------------

Env:

~/inverting-proxy$ gcloud --version
Google Cloud SDK 344.0.0
alpha 2021.06.04
app-engine-go 1.9.72
app-engine-python 1.9.98
beta 2021.06.04
bq 2.0.69
core 2021.06.04
gsutil 4.62
~/inverting-proxy$ go version
go version go1.13.9 linux/amd64

@ravwojdyla
Copy link
Contributor Author

This fixed the make deploy but the apps are not actually properly deployed, please see #93

@ojarjur
Copy link
Collaborator

ojarjur commented Oct 7, 2022

Thanks for the report and debugging steps, @ravwojdyla

I'll take a look and see what we need to do to get the App Engine deployment working again with the latest changes to App Engine.

@ojarjur
Copy link
Collaborator

ojarjur commented Oct 8, 2022

Thanks for the change.

When I tried a deployment with the new runtime I've found that there are a bunch of other things I had to fix, but this is a move in the right direction (and the old, deprecated runtime doesn't work anymore anyway), so I'm going to merge this as is and then apply my additional fixes on top of it.

@ojarjur ojarjur merged commit ac567e2 into google:master Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants