Add retries to read request and write response calls to proxy #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ojarjur
reviewed
May 19, 2022
The goal is to avoid failing the end user request in case of a transient network connectivity error or another internal proxy error when getting request from the proxy, assuming it succeeds on one of the next attempts.
The goal is to avoid failing the end user request in case of a transient network connectivity error or another internal proxy error when forwarding a response to the proxy, assuming it succeeds on one of the next attempts. The retries are only applied to errors that occur before the proxy has read more than the first 4096 bytes of the response body.
ojarjur
approved these changes
Jul 1, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The retries are supposed to overcome transient network connectivity errors and other internal server errors when reading request or writing response.