Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ios 13 support changes - Perfecto contribution #317

Closed
wants to merge 2 commits into from

Conversation

mickelluchko
Copy link

As of iOS 13, Apple requires SSL connection with Web inspector.
Changes tested on Mac OS X Mojave (libimobiledevice master) with latest appium server on an iPhone running iOS 13 beta 3.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@mickelluchko
Copy link
Author

I signed it!

@mickelluchko
Copy link
Author

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

I signed it!

@zivforshtat
Copy link

CLA for Perfecto Mobile has been completed.

@averytallguy
Copy link

When is this likely to go live?

@artygus
Copy link
Collaborator

artygus commented Jul 17, 2019

hi @mickelluchko, thanks for contribution! PR needs some cleanup: unnecessary comments should be stripped, code duplications removed, I'm sure global variables could be avoided, etc. Also please stick to original code formatting

@mickelluchko
Copy link
Author

no problem

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

code cleaning
@pattu777
Copy link

Any timelines when this is gonna be merged..!!

@mneumark
Copy link

Any updates on this? iOS 13 is out now....

@Pavel-DV
Copy link

Someone please fix this problem. I have been waiting for a very long time. No more strength to wait. I'm exhausted.

@artygus
Copy link
Collaborator

artygus commented Sep 24, 2019

@Pavel-DV it's an open source project, you're always welcome to contribute. this PR is very hacky, it does break functionality and can't be merged without extra work

@artygus
Copy link
Collaborator

artygus commented Sep 24, 2019

Work is in progress. ETA is next Monday

@vasogiamarelou
Copy link

Hello, any updates on the PR? Is it going to be merged soon? Thanks

@artygus
Copy link
Collaborator

artygus commented Oct 1, 2019

@vasogiamarelou almost there, I think tomorrow beta will be out

UPD: a bit more required, new ETA is this weekend

@artygus artygus mentioned this pull request Oct 4, 2019
@artygus artygus closed this in #329 Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants