Skip to content
This repository has been archived by the owner on Jan 5, 2023. It is now read-only.

Lack of unit tests #127

Closed
IgorGanapolsky opened this issue Feb 23, 2015 · 10 comments
Closed

Lack of unit tests #127

IgorGanapolsky opened this issue Feb 23, 2015 · 10 comments

Comments

@IgorGanapolsky
Copy link

Hello, how come you don't have an androidTest directory in your project, replete with unit tests? Don't you want budding developers to look at your code and learn how to unit test?

@PaulRashidi
Copy link
Contributor

Stay tuned.

@soniccat
Copy link

yes, it would be great

@tasomaniac
Copy link

Don't say that. iosched is an example project and shows the best practices in Android.

@IgorGanapolsky
Copy link
Author

@tasomaniac I hope you are joking. There's lots of convoluted and unorganized code in iosched. It would be great if they used a pattern like MVP or Dagger, but alas...

@tasomaniac
Copy link

I was being sarcastic :)

But seriously, even it has some problems it is the go to place for most of the developers to learn something. I remember I was learning Android programming with the first version of the app years ago. I also learned how to make 2pane layout properly on tablets with iosched.

Still, it needs tests :)

@IgorGanapolsky
Copy link
Author

@tasomaniac Umm no. It doesn't implement RecyclerView, it uses a very convoluted implementation of Toolbar tabs. It is by no means a go-to app for new developers to learn how to do things. Unless they wanna learn the wrong way!

@cristianoliveira
Copy link

Following this discussion I am also interested in Unit Test examples.

@IgorGanapolsky
Copy link
Author

I am interested in the 2015 version of iosched. Not interested in 2014
anymore.
On Jul 6, 2015 9:34 PM, "Cristian Oliveira" notifications@github.com
wrote:

Following this discussion I am also interested in Unit Test examples.


Reply to this email directly or view it on GitHub
#127 (comment).

@cristianoliveira
Copy link

Will be developed with Unit Test? So I too :P

@PaulRashidi
Copy link
Contributor

We've added some unit tests and will be adding more over time. We've also added AndroidTests for some features in 2015 source.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants