Skip to content
This repository has been archived by the owner on Dec 5, 2022. It is now read-only.

Pull in shed as an official dependency #46

Closed
jeffposnick opened this issue Dec 21, 2014 · 6 comments
Closed

Pull in shed as an official dependency #46

jeffposnick opened this issue Dec 21, 2014 · 6 comments

Comments

@jeffposnick
Copy link
Contributor

It looks like shed is packaged as an npm module, but I don't think it's published. (Unless I'm missing it somewhere.)

We should work with @wibblymat to figure out whether we can start pulling it in via package.json instead of manually copying the source into the project (which was done in #26).

@jeffposnick
Copy link
Contributor Author

#54 implements a stop-gap approach of pulling in the #master branch via bower.

@jeffposnick
Copy link
Contributor Author

Hey @wibblymat, what's your timeline for releasing something official?

We're currently [pulling in] "shed": "wibblymat/shed#84fe1e0cd15fd633db9356ce597e58e7483a83da" and I have a feeling you've made some changes in the past few weeks. Anything we should know about/update to?

@wibblymat
Copy link
Contributor

Not sure why I didn't see this issue earlier. I have made a bunch of changes recently, and I think the stuff around upgrade flow is broken in the version you are using.

I'll publish to npm and then create a PR here to use it.

@jeffposnick
Copy link
Contributor Author

Thanks, @wibblymat! Right now we're using bower to pull in all our client-side JS dependencies, so the gulp build process might have to be tweaked a bit if you're going to use npm.

@wibblymat
Copy link
Contributor

No worries, I published to Bower too.

@jeffposnick
Copy link
Contributor Author

This was fixed in #499

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants