This repository has been archived by the owner on Dec 5, 2022. It is now read-only.
Add in support for queueing and retrying failed Google Analytics pings. #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 21, 2014
|
(This closes #29) |
| shed.router.get('https://www.google-analytics.com/collect?:ignored', handleAnalyticsCollectionRequest); | ||
| shed.router.get('https://ssl.google-analytics.com/collect?:ignored', handleAnalyticsCollectionRequest); | ||
|
|
||
| shed.router.get('http://www.google-analytics.com/analytics.js', shed.networkFirst); |
There was a problem hiding this comment.
One's HTTP and one's HTTPS. As far as I could tell, I couldn't just register a domain independent of the protocol.
I'll sync up with Mat about that. It's similar to wibblymat/shed#17
|
Reviewed |
|
I copied over (#46 tracks the fact that copying over this library manually isn't a good idea moving forward.) |
|
Ack on #46. LGTM. |
ebidel
added a commit
that referenced
this pull request
Dec 21, 2014
Add in support for queueing and retrying failed Google Analytics pings.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @ebidel @devnook
This adds in logic to queue and retry failed Google Analytics requests, similar to what's implemented in the public sample.
It also updates the
shedlibrary to the latest version. (See #46, which tracks getting the library added as a real dependency that could be pulled in and updated automatically.)Additionally, I added a wrapper library for IndexedDB, written by a Googler, Joshua Bell, and published in a gist. I need to reach out to him to figure out what his plansare with the library, and ideally we'd pull this in as an official dependency as well.
Longer term, I think I will refactor everything in
shed-offline-analytics.jsto be a standalone "plugin" library forshedthat we could then pull in as another dependency, but I want to speak to @wibblymat about that first, and figured getting the basic functionality reviewed and integrated into this project first made sense.