Skip to content
This repository has been archived by the owner on Dec 5, 2022. It is now read-only.

Page features that need to be updated dynamically #93

Closed
5 of 6 tasks
ebidel opened this issue Jan 6, 2015 · 3 comments
Closed
5 of 6 tasks

Page features that need to be updated dynamically #93

ebidel opened this issue Jan 6, 2015 · 3 comments
Milestone
Phase 1

Comments

@ebidel
Copy link
Contributor

ebidel commented Jan 6, 2015

Noting what needs to change. I've done some of this in #92

  • Need a template variable for pages to set the masthead bg color. This is done through a class:
    <header class="masthead bg-medium-grey" layout vertical> (e.g. "bg-medium-grey" in this example).
  • nav bar selection updates on new page navigation. #navbar paper-tabs.selected needs to reflect the current page. Ideally, this would be data-bound to the url route <paper-tabs selected="{{route}}" valueattr="route"><paper-tab route="home"><paper-tab..>,
  • similarly, drawer panel nav updates to selected route.
  • the id of body: <body id="page-PAGENAME">, where PAGENAME is 'about', 'home', 'offsite', 'onsite',...etc.
  • <title>
  • <meta> tags that need to change
@devnook devnook self-assigned this Jan 6, 2015
@devnook
Copy link
Contributor

devnook commented Jan 6, 2015

I noticed drawer panel nav is outside of the main template is="autobinding", which makes it impossible to bind to the current route. Any reasons I should not move it inside the template (before I do so)?

@ebidel
Copy link
Contributor Author

ebidel commented Jan 6, 2015

We can move it back if needed.

@ebidel
Copy link
Contributor Author

ebidel commented Jan 20, 2015

Marking this as fixed. I think we've got it covered. The only open one is if page <meta> should change. but I think the generic one in the layout file is probably fine.

@ebidel ebidel closed this as completed Jan 20, 2015
@ebidel ebidel added this to the Phase 1 milestone Jan 20, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Phase 1
Development

No branches or pull requests
2 participants
@ebidel @devnook